Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Triple Threat grenade indicators #647

Merged
merged 3 commits into from
Jun 19, 2023
Merged

Add Triple Threat grenade indicators #647

merged 3 commits into from
Jun 19, 2023

Conversation

uniboi
Copy link
Contributor

@uniboi uniboi commented Jun 8, 2023

Adds grenade indicators for projectiles shot by the triple threat.
That's it

@GeckoEidechse GeckoEidechse added needs testing Changes from the PR still need to be tested almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge labels Jun 8, 2023
@uniboi
Copy link
Contributor Author

uniboi commented Jun 17, 2023

had to compress this to hell and back for github
https://github.com/R2Northstar/NorthstarMods/assets/64006268/53b13706-bd7b-4992-84e1-ecece0d3b83b

F1F7Y
F1F7Y approved these changes Jun 19, 2023
View reviewed changes
Copy link
Member

@F1F7Y F1F7Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes work in private match, was able to still join servers without this PR without any problems.

catornot
catornot approved these changes Jun 19, 2023
View reviewed changes
Copy link
Member

@catornot catornot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the grenade indicator worked.

Titanfall.2.2023-06-19.13-31-16.mp4

@GeckoEidechse GeckoEidechse removed needs testing Changes from the PR still need to be tested almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge labels Jun 19, 2023
@GeckoEidechse GeckoEidechse changed the title Triple threat grenade indicators Add Triple Threat grenade indicators Jun 19, 2023
@GeckoEidechse
Copy link
Member

IIRC Titanfall1 also had this so this is a parity change.

@GeckoEidechse GeckoEidechse merged commit 9620bb2 into R2Northstar:main Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@F1F7Y F1F7Y F1F7Y approved these changes

@catornot catornot catornot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Northstar Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@uniboi @GeckoEidechse @catornot @F1F7Y